Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckeditor5-dev-env should require webpack (due to ckeditor5-dev-utils) #11300

Closed
pomek opened this issue Feb 17, 2022 · 1 comment
Closed

ckeditor5-dev-env should require webpack (due to ckeditor5-dev-utils) #11300

pomek opened this issue Feb 17, 2022 · 1 comment
Assignees
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pomek
Copy link
Member

pomek commented Feb 17, 2022

📝 Provide detailed reproduction steps (if any)

The issue is related to ckeditor/ckeditor5-package-generator#89.

  1. Install @ckeditor/ckeditor5-dev-env
  2. Use any function exposed by the package, e.g.:
/**
 * @license Copyright (c) 2021-2022, CKSource Holding sp. z o.o. All rights reserved.
 * For licensing, see LICENSE.md.
 */

'use strict';

const { generateChangelogForSinglePackage } = require( '@ckeditor/ckeditor5-dev-env' );

generateChangelogForSinglePackage( {
	skipLinks: true
} );

✔️ Expected result

No error.

❌ Actual result

(node:8327) UnhandledPromiseRejectionWarning: Error: Cannot find module 'webpack'
Require stack:
- /Users/pomek/Projects/cksource/ckeditor5-zenhub-integration/node_modules/@ckeditor/ckeditor5-dev-utils/lib/builds/getdllpluginwebpackconfig.js
- /Users/pomek/Projects/cksource/ckeditor5-zenhub-integration/node_modules/@ckeditor/ckeditor5-dev-utils/lib/builds/index.js
- /Users/pomek/Projects/cksource/ckeditor5-zenhub-integration/node_modules/@ckeditor/ckeditor5-dev-utils/lib/index.js
- /Users/pomek/Projects/cksource/ckeditor5-zenhub-integration/node_modules/@ckeditor/ckeditor5-dev-env/lib/release-tools/tasks/generatechangelogforsinglepackage.js
- /Users/pomek/Projects/cksource/ckeditor5-zenhub-integration/node_modules/@ckeditor/ckeditor5-dev-env/lib/index.js
- /Users/pomek/Projects/cksource/ckeditor5-zenhub-integration/scripts/release/changelog.js

❓ Possible solution

Add the "webpack" dependency to @ckeditor/ckeditor5-dev-env, as ckeditor5-dev-utils defines it as a peer dependency.

@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. squad:platform Issue to be handled by the Platform team. package:dev labels Feb 17, 2022
@pomek pomek self-assigned this Feb 17, 2022
@pomek pomek added this to the iteration 51 milestone Feb 17, 2022
@pomek
Copy link
Member Author

pomek commented Feb 17, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

1 participant