Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar button tooltips should also be visible for keyboard users – let's try again #12067

Closed
Reinmar opened this issue Jul 15, 2022 · 1 comment · Fixed by #12262
Closed

Toolbar button tooltips should also be visible for keyboard users – let's try again #12067

Reinmar opened this issue Jul 15, 2022 · 1 comment · Fixed by #12262
Assignees
@oleq
Labels
domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 56 (v35...

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 15, 2022

We first introduced tooltips to focus buttons in #5581. It seemed very simple.

However, in #12066 we figured out that it introduces some annoying UX-glitches.

We decided to revert the original fix for #5581. And try again.

Steps:

  1. Let's try to figure out a better, more sophisticated but feasible solution.
  2. Let's implement it.
  3. If the outcome of step 1. will be "it's damn tricky, we don't have enough time now", let's go with an original solution to Toolbar button tooltips should also be visible for keyboard users #5581 but with some small improvements:
    • turning the alignment menu to horizontal
    • removing tooltips for buttons with visual text labels
@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". squad:features Issue to be handled by the Features team. domain:accessibility This issue reports an accessibility problem. labels Jul 15, 2022
This was referenced Jul 15, 2022
Closed
Closed
Closed
@mlewand mlewand mentioned this issue Jul 22, 2022
Closed
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 10, 2022
@oleq oleq mentioned this issue Aug 11, 2022
Merged
14 tasks
@oleq
Copy link
Member

oleq commented Aug 11, 2022

FYI: A new implementation preview in #12262.

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 22, 2022
@CKEditorBot CKEditorBot added this to the iteration 56 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 56 (v35.1.0)
Development

Successfully merging a pull request may close this issue.

Implemented a Tooltip plugin to handle the JS-driven tooltip system across the UI ckeditor/ckeditor5
3 participants
@Reinmar @oleq @CKEditorBot