MultiRootEditor#editable
contains a random editable and may be harmful
#13582
Labels
package:core
package:editor-multi-root
resolution:expired
This issue was closed due to lack of feedback.
squad:collaboration
Issue to be handled by the Collaboration team.
squad:core
Issue to be handled by the Core team.
type:improvement
This issue reports a possible enhancement of an existing feature.
📝 Provide a description of the improvement
Follow-up after #13532.
After introducing
MultiRootEditor
editor type and making the editor-related classes compatible with parent classes, it appeared that there is a mismatch witheditable
property. This property is expected onEditorUIView
however it does not make sense forMultiRootEditorUIView
as this type of editor has many editables.In general, the property is not used a lot but it is used in some places.
My initial proposal for this problem is to remove
editable
property fromEditorUIView
. All places where it is used, should try using something else andEditorUIView
or other class should provide necessary API. For example,editable
is used by balloon toolbar. Maybe instead we can provide.getFocusedEditable()
that could be used instead?A different route would be to make
MultiRootEditorUIView
not extendEditorUIView
but this is not a simple change either and it means that some parts of our code will not support multi-root. I'd rather go the opposite direction - generalize the solutions and try to make the code handle multiple editables.The text was updated successfully, but these errors were encountered: