Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiRootEditor#editable contains a random editable and may be harmful #13582

Closed
scofalik opened this issue Feb 28, 2023 · 2 comments
Closed
Labels
package:core package:editor-multi-root resolution:expired This issue was closed due to lack of feedback. squad:collaboration Issue to be handled by the Collaboration team. squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@scofalik
Copy link
Contributor

📝 Provide a description of the improvement

Follow-up after #13532.

After introducing MultiRootEditor editor type and making the editor-related classes compatible with parent classes, it appeared that there is a mismatch with editable property. This property is expected on EditorUIView however it does not make sense for MultiRootEditorUIView as this type of editor has many editables.

In general, the property is not used a lot but it is used in some places.

My initial proposal for this problem is to remove editable property from EditorUIView. All places where it is used, should try using something else and EditorUIView or other class should provide necessary API. For example, editable is used by balloon toolbar. Maybe instead we can provide .getFocusedEditable() that could be used instead?

A different route would be to make MultiRootEditorUIView not extend EditorUIView but this is not a simple change either and it means that some parts of our code will not support multi-root. I'd rather go the opposite direction - generalize the solutions and try to make the code handle multiple editables.

@scofalik scofalik added type:improvement This issue reports a possible enhancement of an existing feature. package:core squad:collaboration Issue to be handled by the Collaboration team. squad:core Issue to be handled by the Core team. package:editor-multi-root labels Feb 28, 2023
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Mar 31, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:core package:editor-multi-root resolution:expired This issue was closed due to lack of feedback. squad:collaboration Issue to be handled by the Collaboration team. squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants