-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using Listbox pattern for dropdowns #13668
Comments
@mmotyczynska could you confirm? 😀 |
In #13250 we fixed accessibility for Font size, Font family and Heading features. We decided to go with a different approach than described in this ticket. Instead of using Listbox pattern we used Menu pattern as it seems to be more relevant in the text editor. As the next step we are using the same approach to cover other dropdown lists in the editor:
This fix however will not be applied to grid-like dropdown lists yet (color grids, lists, special characters etc.). We will have to verify which pattern will be most appropriate for grids. |
Thanks @mmotyczynska, and "Text alignment" falls under which category? |
That's a good question. Text alignment looks like a list but it's actually implemented as a toolbar with buttons that are vertically aligned. So I'd say it's a third category. Two other features implemented in the same way are Image styles and Highlight (this one horizontally aligned). All three of these features have already improved accessibility. What I mean by that is that screen readers correctly announce the name of the feature and, after opening a dropdown, they announce which option is selected. And when you're navigating through the options in the dropdown, it also announces whether the option is selected or not. |
I think @Mgsy we may close this ticket and reach out to our support contact so that we improved the accessibility of the dropdowns but in a different way, and it's gonna be available in the next release. WDYT? |
📝 Provide a description of the improvement
This improvement is about considering using the Listbox pattern for dropdown buttons, e.g. "Text alignment", "Font family", "Font size" and "Font color" in the toolbar.
Things to consider:
If you'd like to see this improvement implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: