Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find and replace feature #1430

Closed
addsimm opened this issue Dec 24, 2018 · 3 comments
Closed

Find and replace feature #1430

addsimm opened this issue Dec 24, 2018 · 3 comments
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. Epic package:find-and-replace squad:features Issue to be handled by the Features team. status:discussion support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@addsimm
Copy link

addsimm commented Dec 24, 2018

🆕 Feature request

CKEditor 5

as the title says ..

I googled around and looked in the docs, but nothing on document search

if not how can I / we make one?

Thanks!


If you'd like this feature to be introduced add 👍 to this ticket.

@oleq oleq changed the title is there a way for the user to search a document? Find (search) in document feature Dec 31, 2018
@oleq oleq added status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). candidate:backlog labels Dec 31, 2018
@oleq
Copy link
Member

oleq commented Dec 31, 2018

Hi @addsimm! There's no such feature in CKEditor 5. And quite likely you're the first one to request it so we're gonna keep track of thumbs-ups here in this issue.

Anyway:

  • Could you tell us what would the users of your app use the feature for? (in other words: what's the use-case?)
  • What would you like to see in this feature? Just find or find&replace? What options?
  • Have you used the Find/Replace plugin in CKEditor 4 before? If so, what was it like to use it? (OK/so–so/total distaster)

As for the implementation, we'd probably use the markers API to highlight the results and the TreeWalker to traverse the model to search for matches.

Slightly related #1257.

cc @Reinmar

@Reinmar Reinmar added this to the backlog milestone Mar 5, 2019
@Reinmar
Copy link
Member

Reinmar commented Apr 5, 2019

This feature requires #1257.

@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Jul 16, 2020
@mlewand mlewand modified the milestones: backlog, iteration 44 May 17, 2021
@mlewand mlewand added Epic domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. labels May 17, 2021
@mlewand mlewand added the squad:features Issue to be handled by the Features team. label May 25, 2021
@AnnaTomanek AnnaTomanek changed the title Find (search) in document feature Find and replace feature Jun 8, 2021
@mlewand
Copy link
Contributor

mlewand commented Jun 30, 2021

🎉 We published the feature today as @ckeditor/ckeditor5-find-and-replace npm package 🎉

We deployed it to our docs, so you can give it a try in our latest find and replace feature guide.

Fixed with 2528e72.

@mlewand mlewand closed this as completed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. Epic package:find-and-replace squad:features Issue to be handled by the Features team. status:discussion support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

5 participants