Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect import statement in the "Creating a custom thread view with a new template" guide #15586

Closed
mabryl opened this issue Dec 22, 2023 · 0 comments
Assignees
Labels
squad:qa Issue to be handled by the QA team. support:2 An issue reported by a commercially licensed client. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).

Comments

@mabryl
Copy link
Contributor

mabryl commented Dec 22, 2023

📝 Provide a description of requested docs changes

In the Creating a custom thread view with a new template guide there's an incorrect import in one of the code snippets.

Currently the import statement looks as follows:

import { UIModel, addListToDropdown, createDropdown } from '@ckeditor/ckeditor5-ui';

image

The issue is that there is no UIModel in the @ckeditor/ckeditor5-ui package.

The import could be altered to look like this:

import { Model as UIModel, createDropdown, addListToDropdown } from '@ckeditor/ckeditor5-ui';
@mabryl mabryl added type:docs This issue reports a task related to documentation (e.g. an idea for a guide). support:2 An issue reported by a commercially licensed client. labels Dec 22, 2023
@mabryl mabryl self-assigned this Dec 22, 2023
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 22, 2023
@Mgsy Mgsy closed this as completed Dec 27, 2023
@Mgsy Mgsy added the squad:qa Issue to be handled by the QA team. label Dec 27, 2023
@Mgsy Mgsy added this to the iteration 70 milestone Dec 27, 2023
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:qa Issue to be handled by the QA team. support:2 An issue reported by a commercially licensed client. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Development

No branches or pull requests

3 participants