Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckeditor5-premium-features does not include src/ #17576

Closed
bendemboski opened this issue Dec 3, 2024 · 1 comment
Closed

ckeditor5-premium-features does not include src/ #17576

bendemboski opened this issue Dec 3, 2024 · 1 comment
Labels
resolution:resolved This issue was already resolved (e.g. by another ticket). type:bug This issue reports a buggy (incorrect) behavior.

Comments

@bendemboski
Copy link
Contributor

bendemboski commented Dec 3, 2024

This is related to #17575.

I believe all packages in the CKEditor5 ecosystem publish src/ folders (even the closed-source collaboration plugins like @ckeditor/ckeditor5-comments) except ckeditor5-premium-features. This means that, for the reasons described in #17575, importing from ckeditor5-premium-features is risky, as it has the potential to make the module graph "hop over" from dist/ to src/ because even though all of its imports from @ckeditor/ckeditor5-* packages are from their dist/ folders, as #17575 describes, importing from their dist/ folders can cause the module graph to "hop over".

My workaround, as described in #17575, is to import from src/ folders and not consume dist/ until #17575 is addressed. This means I can't use ckeditor5-premium-features at all because it does not publish a src/ folder.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@bendemboski bendemboski added the type:bug This issue reports a buggy (incorrect) behavior. label Dec 3, 2024
@filipsobol
Copy link
Member

The src folders in other packages are only there for backward compatibility with the legacy installation methods and will be removed in the future. Because the ckeditor5-premium-features package was specifically created for new installation methods and doesn't need to be backward compatible, it doesn't have the src folder.

See my reply in the issue you linked for more information.

@Witoso Witoso added the resolution:resolved This issue was already resolved (e.g. by another ticket). label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:resolved This issue was already resolved (e.g. by another ticket). type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants