Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After autoformatter was triggered, pressing esc should make undo #2364

Closed
Reinmar opened this issue Oct 31, 2016 · 12 comments
Closed

After autoformatter was triggered, pressing esc should make undo #2364

Reinmar opened this issue Oct 31, 2016 · 12 comments
Labels
package:autoformat resolution:expired This issue was closed due to lack of feedback. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 31, 2016

It's natural to try to press Esc after something unwanted happened.

@fredck
Copy link
Contributor

fredck commented Nov 2, 2016

I've never heard or thought of Esc for such case? "Undo" sounds the right thing for me.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 3, 2016

I'm always using Esc. Definitely in GDocs and AFAIR in MSWord as well. Esc is the first thing I do once something unintended happened.

@fredck
Copy link
Contributor

fredck commented Nov 3, 2016

Ok... you may have got used to it and, for you, it sounds natural, but I still find it weird... "Escape" really gets this connotation of "exit" or "close", but never "undo", for me. Maybe this is something that programmers may have, based on some IDE or something.

Anyway, less is better, so let's be sure we want to have it now. Such enhancements can easily land at any point later.

@wwalc
Copy link
Member

wwalc commented Feb 28, 2017

Esc in MS Word does not work in case of changes added by autoformatter. At least in case of bulleted lists made out of an asterisk. Undo (Ctrl Z) does work.

@scofalik
Copy link
Contributor

scofalik commented Mar 1, 2017

I always do Ctrl + Z

@Reinmar
Copy link
Member Author

Reinmar commented Mar 1, 2017

Odd... am I the only one using Esc? :D

@Reinmar
Copy link
Member Author

Reinmar commented Nov 15, 2017

Wiktor asked me whether Backspace shouldn't revert autoformatting too. AFAIR, that's what some editors do (but I'm too lazy now to check ;)). Worth considering.

@wwalc
Copy link
Member

wwalc commented Nov 15, 2017

I got used to use Backspace to revert autoformatting (thanks to Google Docs, where it works this way).

@Reinmar
Copy link
Member Author

Reinmar commented Nov 9, 2018

Handling Backspace is important on mobile devices where undo may not be easily available and Esc does not exist.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-autoformat Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:autoformat labels Oct 9, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:autoformat resolution:expired This issue was closed due to lack of feedback. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

7 participants