Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make basic styles autoformat implementations execute commands #2395

Closed
scofalik opened this issue May 17, 2019 · 2 comments · May be fixed by ckeditor/ckeditor5-autoformat#71
Closed

Make basic styles autoformat implementations execute commands #2395

scofalik opened this issue May 17, 2019 · 2 comments · May be fixed by ckeditor/ckeditor5-autoformat#71
Labels
package:autoformat resolution:duplicate This issue is a duplicate of another issue and was merged into it. status:discussion type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@scofalik
Copy link
Contributor

Instead of setting attribute by hand, InlineAutoformatEditing implementations should use command.execute() to provide better integration possibilities with other parts of the editor.
@scofalik scofalik self-assigned this May 17, 2019
@scofalik
Copy link
Contributor Author

Unfortunately, the side effect of this change without any other changes is this issue: https://github.com/ckeditor/ckeditor5-undo/issues/44.

@Reinmar
Copy link
Member

Reinmar commented May 27, 2019

DUP of https://github.com/ckeditor/ckeditor5-autoformat/issues/7.

@Reinmar Reinmar closed this as completed May 27, 2019
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-autoformat Oct 9, 2019
@mlewand mlewand added resolution:duplicate This issue is a duplicate of another issue and was merged into it. status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:autoformat labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:autoformat resolution:duplicate This issue is a duplicate of another issue and was merged into it. status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make basic styles autoformat implementations execute commands ckeditor/ckeditor5-autoformat
3 participants
@Reinmar @scofalik @mlewand