Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Editor.build into Editor.builtinPlugins and Editor.defaultConfig #2892

Closed
Reinmar opened this issue Jul 10, 2018 · 0 comments
Closed
Assignees
Labels
package:core type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 10, 2018

Part of #1038.

Let's split this single Editor.build property to make it less confusing. We've seen that people tried to edit it like this:

ClassicEditor.build = {
	plugins: [
		EssentialsPlugin,
		UploadadapterPlugin,
		AutoformatPlugin,
		BoldPlugin,
		ItalicPlugin,
		BlockquotePlugin,
		EasyimagePlugin,
		HeadingPlugin,
		ImagePlugin,
		ImagecaptionPlugin,
		ImagestylePlugin,
		ImagetoolbarPlugin,
		ImageuploadPlugin,
		LinkPlugin,
		ListPlugin,
		ParagraphPlugin
	],
	// WRONG PLACE!
	image: {
		toolbar: [ ... ]
        },
	config: {
		toolbar: { ... },
		// IT SHOULD BE HERE!
		image: {
			toolbar: [
				'imageStyle:full',
				'imageStyle:side',
				'|',
				'imageTextAlternative'
			]
		},
		language: 'en'
	}
};

Two separate properties will be safer:

ClassicEditor.builtinPlugins = [
	// ...
];

ClassicEditor.defaultConfig = {
	toolbar: { ... },
	image: {
		toolbar: [
			'imageStyle:full',
			'imageStyle:side',
			'|',
			'imageTextAlternative'
		]
	},
	language: 'en'
};
@Reinmar Reinmar self-assigned this Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-alignment Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-autoformat Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-basic-styles Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-build-balloon Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-build-classic Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-build-decoupled-document Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-build-inline Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-font Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-highlight Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-ui Jul 10, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-table Jul 10, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-core Oct 9, 2019
@mlewand mlewand added this to the iteration 19 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:core labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:core type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants