Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixer for list feature. #2964

Closed
scofalik opened this issue Feb 27, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-list#42
Closed

Fixer for list feature. #2964

scofalik opened this issue Feb 27, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-list#42
Labels
package:list status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@scofalik
Copy link
Contributor

List feature is a complicated one, because it needs some precise model structure. Some model states, connected with lists, are incorrect (even though they are correct with schema, etc.). For example, a list cannot start with indented element:

<listItem indent=2>Foo.</listItem>
<listItem indent=3>Bar.</listItem>

We "are able" to created such model structure even without writing any complicated code. For instance, we could wrap part of a list in another element, or copy+paste it.

For this reason, we need some kind of fixer for list feature, that would fix those wrong structures:

  1. It would be fired with high priority on each change event.
  2. If incorrect structure is noticed, it will change it -- probably without using Batch API - the change has to have an immediate impact and probably should not be seen by other features (undo, OT, etc.).

This issue is to discuss what kind of incorrect list feature model structure we may encounter and how the fixer should look like.

Reinmar referenced this issue in ckeditor/ckeditor5-list Mar 24, 2017
Feature: Added support for nested lists.

These changes close a wide range of issues. Closes #8. Closes #9. Closes #30. Closes #36. Closes #37. Closes #38. Closes #39. Closes #40. Closes #41. Closes #44. Closes #45.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-list Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:list labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:list status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants