Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bender.tools.defineEditorCreatorMock #32

Closed
Reinmar opened this issue Oct 14, 2015 · 3 comments
Closed

Add bender.tools.defineEditorCreatorMock #32

Reinmar opened this issue Oct 14, 2015 · 3 comments
Assignees
@Reinmar
Labels
resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior).

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 14, 2015

Required for https://github.com/ckeditor/ckeditor5-core/issues/26. Needs: #31.

Since all editors need creators we'll often face a situation when we have to define some.
@Reinmar Reinmar self-assigned this Oct 14, 2015
@Reinmar
Copy link
Member Author

Reinmar commented Oct 14, 2015

Actually... perhaps it'll be better to move this to ckeditor5-core, but I'll need to check if we can have a bender plugin there too.

@Reinmar
Copy link
Member Author

Reinmar commented Oct 14, 2015

Yup. This method does not make sense here. We must find some way to keep tools in the repo they are related too. Otherwise it will be a mess. I'll try with 0 magic first and keep other repos' tools in their respective tests/_tools/tools.js. I will also define a namespace scheme.

@Reinmar Reinmar closed this as completed Oct 14, 2015
@Reinmar Reinmar added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Oct 14, 2015
@Reinmar
Copy link
Member Author

Reinmar commented Oct 14, 2015

PS. I will add this method as a part of https://github.com/ckeditor/ckeditor5-core/issues/26.

@Reinmar Reinmar modified the milestone: 0.1.0 Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Reinmar