Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: provide a Editor creation factory #6015

Closed
fredck opened this issue Dec 19, 2019 · 2 comments
Closed

Core: provide a Editor creation factory #6015

fredck opened this issue Dec 19, 2019 · 2 comments
Assignees
Labels
package:core package:editor-balloon package:editor-classic package:editor-decoupled package:editor-inline resolution:expired This issue was closed due to lack of feedback. status:stale type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@fredck
Copy link
Contributor

fredck commented Dec 19, 2019

Before proposing anything, let me illustrate the two cases I've faced recently, which motivated this issue.

Case 1

While working on ckeditor/ckeditor5-markdown-gfm#30, I've noticed that, although the plugin is setting editor.data.processor to the GFM data processor, the editor classes (classic, inline, etc.) are in any case pointlessly (at that point) setting that same property to the HTML data processor (which later on is overwritten by the plugin).

I figured that it would be safe to set the data processor only after initing all plugins, if no plugin set it. Then, I've also figured that this would involve touching all four official editor classes, basically deleting and pasting the same lines, in the same places. It would not fix other editors out there though.

Case 2

While coding a custom editor class, it is depressing the amount of copy/paste that has do be done. One does it without even thinking why, copying the boilerplate from the relative documentation guide.

All that sounded overcomplicated and pointless. I see this as a weak part of the API.

Proposal

The creation of a factory that will remove most of the boilerplate from the editor classes and centralize it in a single place.


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 7, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:core package:editor-balloon package:editor-classic package:editor-decoupled package:editor-inline resolution:expired This issue was closed due to lack of feedback. status:stale type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
4 participants