Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in downcast conversion when moving selection between table cells #7899

Closed
oleq opened this issue Aug 21, 2020 · 2 comments
Closed

Crash in downcast conversion when moving selection between table cells #7899

oleq opened this issue Aug 21, 2020 · 2 comments
Labels
package:link package:table resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oleq
Copy link
Member

oleq commented Aug 21, 2020

📝 Provide detailed reproduction steps (if any)

Check out the screencast. I'm attaching everything I did starting from the moment I reloaded the webpage (this may be yet another bugfoot).

Note: I came across this issue when trying to reproduce another one (hence all the noise).

I was testing the Document Editor sample (http://fake.ckeditor.com/ck/5/ckeditor5/build/docs/ckeditor5/latest/examples/builds/document-editor.html)

ckeditorerror.js:70 Uncaught TypeError: element.getCustomProperty(...) is not a function
    at DowncastDispatcher.eval (downcasthelpers.js:1342)
    at DowncastDispatcher.fire (emittermixin.js:218)
    at DowncastDispatcher.convertMarkerRemove (downcastdispatcher.js:391)
    at DowncastDispatcher.convertChanges (downcastdispatcher.js:136)
    at eval (editingcontroller.js:104)
    at View.change (view.js:502)
    at Document.EditingController.listenTo.priority (editingcontroller.js:103)
    at Document.fire (emittermixin.js:218)
    at Document._handleChangeBlock (document.js:331)
    at Model._runPendingChanges (model.js:854)
CKEditorError @ ckeditorerror.js:70
rethrowUnexpectedError @ ckeditorerror.js:122
fire @ emittermixin.js:253
convertMarkerRemove @ downcastdispatcher.js:391
convertChanges @ downcastdispatcher.js:136
eval @ editingcontroller.js:104
change @ view.js:502
EditingController.listenTo.priority @ editingcontroller.js:103
fire @ emittermixin.js:218
_handleChangeBlock @ document.js:331
_runPendingChanges @ model.js:854
change @ model.js:196
_hideFakeVisualSelection @ linkui.js:690
_removeFormView @ linkui.js:395
_hideUI @ linkui.js:464
callback @ linkui.js:303
eval @ clickoutsidehandler.js:45
fire @ emittermixin.js:218
domListener @ emittermixin.js:253

📃 Other details

  • Browser: Chrome
  • OS: Mac
  • CKEditor version: master

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@oleq oleq added the type:bug This issue reports a buggy (incorrect) behavior. label Aug 21, 2020
@oleq oleq changed the title Crash when moving selection between table cells Crash in downcast conversion when moving selection between table cells Aug 21, 2020
@oleq
Copy link
Member Author

oleq commented Aug 21, 2020

The issue comes down to the following steps (note the backwards selection that ends at the beginning of the previous list item):

@oleq oleq added this to the iteration 35 milestone Aug 21, 2020
@Reinmar Reinmar added the release:blocker This issue blocks the upcoming release (is critical). label Aug 21, 2020
@Reinmar Reinmar modified the milestones: iteration 35, iteration 36 Aug 24, 2020
@mlewand mlewand removed the release:blocker This issue blocks the upcoming release (is critical). label Aug 24, 2020
@mlewand
Copy link
Contributor

mlewand commented Aug 24, 2020

Duplicate of #7907

@mlewand mlewand marked this as a duplicate of #7907 Aug 24, 2020
@mlewand mlewand closed this as completed Aug 24, 2020
@mlewand mlewand removed this from the iteration 36 milestone Aug 24, 2020
@mlewand mlewand added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:link package:table resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants