Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLL: Decide what to do with imports in ckeditor5-essentials #8782

Closed
pomek opened this issue Jan 8, 2021 · 1 comment
Closed

DLL: Decide what to do with imports in ckeditor5-essentials #8782

pomek opened this issue Jan 8, 2021 · 1 comment
Labels
domain:extending-builds type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Jan 8, 2021

Provide a description of the task

After introducing the ESlint rule for our imports (#8581), the content of the packages/ckeditor5-essentials/src/essentials.js file does not pass:

import Plugin from '@ckeditor/ckeditor5-core/src/plugin';
import Clipboard from '@ckeditor/ckeditor5-clipboard/src/clipboard';
import Enter from '@ckeditor/ckeditor5-enter/src/enter';
import ShiftEnter from '@ckeditor/ckeditor5-enter/src/shiftenter';
import SelectAll from '@ckeditor/ckeditor5-select-all/src/selectall';
import Typing from '@ckeditor/ckeditor5-typing/src/typing';
import Undo from '@ckeditor/ckeditor5-undo/src/undo';

⬇️ Should it be?

import { Plugin } from 'ckeditor5/src/core';

import { Clipboard } from 'ckeditor5/src/clipboard';
import { Enter, ShiftEnter } from 'ckeditor5/src/enter';
import { SelectAll } from 'ckeditor5/src/select-all';
import { Typing } from 'ckeditor5/src/typing';
import { Undo } from 'ckeditor5/src/undo';

As for now, I'll disable the new rule for the essential package.

@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:dx domain:extending-builds labels Jan 8, 2021
@Reinmar
Copy link
Member

Reinmar commented Jan 25, 2021

⬇️ Should it be?

Yup. Already done.

@Reinmar Reinmar closed this as completed Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:extending-builds type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

2 participants