Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find and replace feature followup regarding checkboxview and used icons. #9980

Closed
mateuszzagorski opened this issue Jun 29, 2021 · 1 comment
Labels
package:find-and-replace resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@mateuszzagorski
Copy link
Contributor

📝 Provide a description of the improvement

Followup from #9959.

Right now there is no easy way for users to style checkboxes. For example, changing checkbox behavior on :checked pseudo-class or altering colors for it would require a lot of additional effort. Checkboxview class should be updated in a way that will allow changes like that without the need to alter the code too much.

Additionally, icons used in the find-and-replace feature are not compatible with icons used for pagination. This should be reviewed and updated to keep everything consistent. 


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@mateuszzagorski mateuszzagorski added type:improvement This issue reports a possible enhancement of an existing feature. squad:features Issue to be handled by the Features team. package:find-and-replace labels Jun 29, 2021
@oleq
Copy link
Member

oleq commented Jul 28, 2021

This will no longer be a problem because of #10229.

@oleq oleq closed this as completed Jul 28, 2021
@oleq oleq added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:find-and-replace resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants