Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari performance with Kioo-generated React nodes #60

Open
OliverM opened this issue Sep 3, 2015 · 6 comments
Open

Safari performance with Kioo-generated React nodes #60

OliverM opened this issue Sep 3, 2015 · 6 comments

Comments

@OliverM
Copy link
Contributor

OliverM commented Sep 3, 2015

Kioo's output causes Safari browsers to hang when moderately complex HTML structures are used. There's a discussion of this issue on the news group here:
https://groups.google.com/forum/#!topic/enfocus/vfS63QhnRXs

A sample project that exhibits the issue is here:
https://github.com/OliverM/kiooform

This was encountered with Kioo 0.4.1 but 0.4.2 still shows the issue.

Creighton, you mentioned there that you'd encountered a similar issue previously, did you have a chance to capture what was going on there?

@OliverM
Copy link
Contributor Author

OliverM commented Sep 4, 2015

Pull request #62 shows captures the issue in the test suite

@ckirkendall
Copy link
Owner

I remember well the issue but I have no idea still what is going on.

@Jell
Copy link

Jell commented Sep 13, 2015

I believe this is the issue: http://dev.clojure.org/jira/browse/CLJS-910

Setting :static-fns to true as a compiler option is the only way for me to run our cljs app in safari. Another way to palliated to this is to avoid nested function calls and to introduce intermediate variables everywhere, but that's not very sustainable.

@Jell
Copy link

Jell commented Sep 13, 2015

PhantomJS has the same issue

@ckirkendall
Copy link
Owner

@Jell thanks for pointing me to this.

@OliverM
Copy link
Contributor Author

OliverM commented Sep 14, 2015

Thanks @Jell, setting :static-fns to true resolves the issue for me (at first inspection). Fantastic to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants