Problem with cents in v6.5.1

[quintavallechristian]

Updating to the last version (coming from 3.8) I noticed all the amounts in my application multiplied by 100. It seems like the format() function does not divide by 100 anymore, so if I pass a value of 100 it will print 100 € (or whatever currency I set).

Rolling back to version 6.4.0 the problem disappears

[ReadingPride]

We had the same problem, although this was just a general composer update for us, not expecting any code breaking or significant changes from it so this caught us out by surprise until it was reported.

[marvinschroeder]

Same problem here.

[hrnicek]

Same problem

[ricardogobbosouza]

Hi @quintavallechristian
Could you share an example of the error?

[marvinschroeder]

@ricardogobbosouza

This problem only occurs with float's.

In v6.4.0 this was the behavior:

money(250, 'EUR') // 2,50 €
money(2.50 * 100, 'EUR') // 2,50 €

In v6.5.1:

money(250, 'EUR') // 2,50 €
money(2.50 * 100, 'EUR') // 250,00 €

[ricardogobbosouza]

Actually, this is expected now

Because 250 is not equal to (2.50 * 100) = 250.0

We have different treatments for integers and floating
https://github.com/cknow/laravel-money/blob/main/src/MoneyParserTrait.php#L32-L74

And with that the option forceDecimals was added
https://github.com/cknow/laravel-money/blob/main/src/Money.php#L73-L76

Maybe this should have been a breaking change and released v7 🤔

[marvinschroeder]

If that is expected now, it is indeed a breaking change and better suited for a new major version.

[ricardogobbosouza]

I treated this as a fix

In v6.4.0

@money(2.50 * 101) = $2.52 // wrong

In v6.5.1:

@money(2.50 * 101) = $252.50 // right

[ricardogobbosouza]

I will remove the latest versions and release v7

[ricardogobbosouza]

Sorry for the trouble with the floating values
Released v7.0.0

[jtomek]

This was indeed a breaking change. Our app reports significant numeric changes to our clients and suddenly we generated quite a number of notifications because all figures suddenly went up by x100. :) We need to add more testing.

[giacomomasseron]

I treated this as a fix

In v6.4.0

@money(2.50 * 101) = $2.52 // wrong

why this should be wrong?