Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.608 gcc -Wall -pedantic build warnings #8

Closed
jaalto opened this issue Feb 8, 2012 · 4 comments
Closed

0.608 gcc -Wall -pedantic build warnings #8

jaalto opened this issue Feb 8, 2012 · 4 comments

Comments

@jaalto
Copy link
Contributor

jaalto commented Feb 8, 2012

FYI,

Debian now builds with hardened CFLAGS to reveal possible problems. I cranked the flags to maximum "-Wall -pedantic". Perhaps some of the issues could be addresses in later releases.

Flags used were:

LDFLAGS="-Wl,-z,relro -Wl,--as-needed"

CFLAGS="-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -Wall -pedantic"

...(this only an exerpt)...

Types.h:88:14: warning: ISO C90 does not support 'long long' [-Wlong-long]
Types.h:89:23: warning: ISO C90 does not support 'long long' [-Wlong-long]

... warning: C++ style comments are not allowed in ISO C90 [enabled by default]

LzmaEnc.c:2159:8: warning: variable 'allocaDummy' set but not used [-Wunused-but-set-variable]

... warning: ISO C90 does not support the 'll' gnu_printf length modifier [-Wformat]

lrzip.c:165:55: warning: ISO C99 requires rest arguments to be used [enabled by default]

main.c:163:2: warning: ISO C does not support the '%Lu' gnu_scanf format [-Wformat]
@ckolivas
Copy link
Owner

Fixed at last in git.

@ariccio
Copy link

ariccio commented Mar 23, 2015

Which commit?

I'm sorry for being pedantic, but I'm curious! :)

@ckolivas
Copy link
Owner

The "fix ISO C warning"s patches.

@ariccio
Copy link

ariccio commented Mar 24, 2015

So, efe3f67, 9756dd3, 90f7228, 2e3eed5, e3598a7 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants