Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No available free games being found #129

Closed
birarda opened this issue Jul 19, 2021 · 13 comments
Closed

No available free games being found #129

birarda opened this issue Jul 19, 2021 · 13 comments
Labels
bug Something isn't working v4

Comments

@birarda
Copy link

birarda commented Jul 19, 2021

Describe the bug

Latest image 1dc78765d875 is not finding available games. User is logged in with exported cookie.

Screenshots or Logs

[2021-07-19 14:23:22.710 +0200] INFO (39 on 1dc78765d875): Successfully refreshed login
user: -
[2021-07-19 14:23:37.779 +0200] INFO (39 on 1dc78765d875): Available free games
user: -
availableGames: []
[2021-07-19 14:23:37.780 +0200] INFO (39 on 1dc78765d875): Unpurchased free games
user: -
purchasableGames: []
@birarda birarda added the bug Something isn't working label Jul 19, 2021
@claabs
Copy link
Owner

claabs commented Jul 19, 2021

I'm aware of this. In the meantime, I think you can just use "onlyWeekly": true, which appears to still be finding games.

@birarda
Copy link
Author

birarda commented Jul 19, 2021

I'm aware of this. In the meantime, I think you can just use "onlyWeekly": true, which appears to still be finding games.

Confirmed that this worked! Thanks. Feel free to close this if you prefer.

Happy to provide any additional debug if you need.

@claabs
Copy link
Owner

claabs commented Jul 19, 2021

I'll keep it open and pin it so others can be aware. I'll look into it when I get a chance...

@claabs claabs pinned this issue Jul 19, 2021
@maximegy
Copy link

Hello,
I just realized a problem.
The program does not seem to redeem all free games.
Indeed, today there are "Offworld Trading Company" and "Obduction" for free. The program has only redeem "Offworld Trading Company".
image
image
image
image

Do I have to pass the "onlyweekly" parameter to "true" for this to work?

Thanks,

Best regards.

@claabs
Copy link
Owner

claabs commented Jul 19, 2021

Do I have to pass the "onlyweekly" parameter to "true" for this to work?

Yes, either set "onlyWeekly": true in config.json, or ONLY_WEEKLY=true if you're using environment variables. Details here.

@manor7777
Copy link

I'm aware of this. In the meantime, I think you can just use "onlyWeekly": true, which appears to still be finding games.

Can confirm it is now detecting games, can't confirm it actually redeems them as i did this weeks manually, but seems fixed!

@CorneliousJD
Copy link

I'm aware of this. In the meantime, I think you can just use "onlyWeekly": true, which appears to still be finding games.

Can confirm it is now detecting games, can't confirm it actually redeems them as i did this weeks manually, but seems fixed!

I can confirm it purchases them when using onlyWeekly: true -- just tested.

Came to report that I didn't think I had redeemed the games in a while so checked and saw this, tested before I manually redeemed :)

Repository owner deleted a comment from jopais2 Aug 11, 2021
@sebastianklein96
Copy link

Although this issue has had no activity for a month, I need to revive it from the dead.

As of today, even with the environment variable ONLY_WEEKLY=true set, and a login cookie as well as successful login, the script only returns an empty array of available weekly games although I would expect array size to equal two (Saints Row as well as Automachef are available as weeklies).

Any progress on this issue?

@CorneliousJD
Copy link

Although this issue has had no activity for a month, I need to revive it from the dead.

As of today, even with the environment variable ONLY_WEEKLY=true set, and a login cookie as well as successful login, the script only returns an empty array of available weekly games although I would expect array size to equal two (Saints Row as well as Automachef are available as weeklies).

Any progress on this issue?

Weird, it's working for me, I redeemed both games successfully with weekly=true and my cookie set.

@claabs claabs added the v4 label Aug 30, 2021
@Pixelartist
Copy link

Pixelartist commented Sep 10, 2021

Hello,

ran the script (added cookie with browser due to the captcha "bug") - and it fails to see any new games.

Incoming env vars:
RUN_ON_STARTUP:
CRON_SCHEDULE:
RUN_ONCE:
Getting settings from JSON: /usr/app/config/config.json
Setting config variables
Run on startup: true
Run once: false

 epicgames-freegames-node@3.0.0 start /usr/app
 node dist/src/index.js

[2021-09-10 12:30:13.379 +0000] INFO  (48 on 16504f996bc4): Checking free games for me@gmail.com
[2021-09-10 12:30:13.441 +0000] DEBUG (48 on 16504f996bc4): Refreshing login session
    user: "me@gmail.com"
[2021-09-10 12:30:21.981 +0000] INFO  (48 on 16504f996bc4): Successfully refreshed login
    user: "me@gmail.com"
[2021-09-10 12:30:21.985 +0000] DEBUG (48 on 16504f996bc4): Getting global free games
    user: "me@gmail.com"
[2021-09-10 12:30:40.612 +0000] DEBUG (48 on 16504f996bc4): Retrieved catalog data for 2880 games
    user: "me@gmail.com"
[2021-09-10 12:30:40.616 +0000] DEBUG (48 on 16504f996bc4): Found 0 unique free games in catalog
    user: "me@gmail.com"
[2021-09-10 12:30:40.617 +0000] INFO  (48 on 16504f996bc4): Available free games
    user: "me@gmail.com"
    availableGames: []
[2021-09-10 12:30:40.619 +0000] DEBUG (48 on 16504f996bc4): Mapping IDs to offer
    user: "me@gmail.com"
[2021-09-10 12:30:40.620 +0000] DEBUG (48 on 16504f996bc4): Offers with updated IDs
    user: "me@gmail.com"
    updatedOffers: []
[2021-09-10 12:30:40.620 +0000] DEBUG (48 on 16504f996bc4): Checking ownership on available games
    user: "me@gmail.com"
[2021-09-10 12:30:40.621 +0000] INFO  (48 on 16504f996bc4): Unpurchased free games
    user: "me@gmail.com"
    purchasableGames: []
Setting cron schedule as 0 12 * * *

Given the sticky problem thread - I switched on the weekly parameter and it was able see the games.
My intention is to run this on my NAS and have it claim the free games for me - if there is anything I can do to debug or help, I am open.

@quzard
Copy link

quzard commented Sep 29, 2021

Do I have to pass the "onlyweekly" parameter to "true" for this to work?

Yes, either set "onlyWeekly": true in config.json, or ONLY_WEEKLY=true if you're using environment variables. Details here.

I found you moved this from In progress to Done.

However, the lasted docker image charlocharlie/epicgames-freegames:dev does not seem to redeem all free games

When "onlyWeekly": false, it only gets the weekly promotion.

@claabs
Copy link
Owner

claabs commented Sep 29, 2021

I believe that's because currently, there are no 100% discount games besides The Escapists, which is this week's free game.

In the past, there have been some games that had a temporary 100% discount that wasn't affiliated with the weekly promotion. That's just not the case currently.

@claabs claabs mentioned this issue Oct 2, 2021
@claabs claabs closed this as completed in c3f92dc Oct 2, 2021
@claabs
Copy link
Owner

claabs commented Oct 2, 2021

@claabs claabs unpinned this issue Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v4
Projects
None yet
Development

No branches or pull requests

8 participants