Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy to access control to disable/enable Discord RPC #19

Open
Davoleo opened this issue Nov 6, 2020 · 3 comments
Open

Easy to access control to disable/enable Discord RPC #19

Davoleo opened this issue Nov 6, 2020 · 3 comments

Comments

@Davoleo
Copy link

Davoleo commented Nov 6, 2020

Winamp RPC tends to override any other RPC that is started later than it.
It'd be useful to be able disable and enable the RPC with an easy to access option without having to go into Winamp Preferences

@clandrew
Copy link
Owner

clandrew commented Nov 6, 2020

I'm trying to think, what would be easier? A hotkey?

@Davoleo
Copy link
Author

Davoleo commented Nov 7, 2020

yeah a hotkey or a button on Winamp gui would work just fine (although I don't know how easy it'd be to do the second one knowing that Winamp GUI is completely custom and drawn by sketch)

Another option could be a configuration option in the plugin settings to hide the RPC when Winamp is paused.

@clandrew
Copy link
Owner

Hiding the RPC when Winamp is paused is definitely doable. Actually come to think of it, someone had a PR to do just that but they ran into Git problems and didn't merge it. I think I can merge it for them... will check on that.

More generally, plug-ins changing Winamp UI seems a bit sketchy, hotkey might be doable if it's absolutely needed though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants