Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe code - Rust native support available now (?) #5209

Closed
cylewitruk opened this issue Nov 12, 2023 · 1 comment
Closed

Unsafe code - Rust native support available now (?) #5209

cylewitruk opened this issue Nov 12, 2023 · 1 comment

Comments

@cylewitruk
Copy link

cylewitruk commented Nov 12, 2023

The comment in the following code block pointing to a PR in rust-lang, which seems to have been superseded by merged PR 109698, maybe warrants a fresh look at the usage of unsafe here?

https://github.com/clap-rs/clap/blob/3aeea916e8e426e8389357a67d9b8f9a1fceba3e/clap_lex/src/ext.rs#L272C24-L272C24

@cylewitruk cylewitruk changed the title Unsafe code block native support resolved (?) Unsafe code - Rust native support available now (?) Nov 13, 2023
@epage
Copy link
Member

epage commented Nov 13, 2023

I wrote rust-lang/rust#109698 based on my work within clap. Our use of unsafe meets the new guidelines that will be stabilized this week. We'll update to the new API when 1.74 becomes our MSRV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants