Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Download dependencies using --platform flag in pip #23

Open
thyming opened this issue Aug 1, 2018 · 3 comments
Open

Download dependencies using --platform flag in pip #23

thyming opened this issue Aug 1, 2018 · 3 comments

Comments

@thyming
Copy link

thyming commented Aug 1, 2018

Currently this project downloads dependencies using pip install, but if you rely on any packages which require a native extension you'll have problems unless you are building from a machine with the same platform (in pip's parlance).

@raymondbutcher
Copy link
Contributor

Hi,

Version 0.11.0 now supports custom build commands (example) which provides a solution to this problem, as you can run any pip commands you want in a custom build script.

But it would be pretty cool if it did this automatically. I wasn't previously aware of the manylinux platform options for pip.

https://github.com/pypa/manylinux
https://blog.zappa.io/posts/zappa-adds-support-for-manylinux-wheels
https://github.com/Miserlou/lambda-packages

Not sure when I'll have time to look into this though.

Cheers!

@thyming
Copy link
Author

thyming commented Feb 1, 2019

would you accept a PR changing the platform default to manylinux, simply updating the flags passed to pip? i can't see how this could be less correct than the default right now, which is whatever platform you happen to run this module on.

@raymondbutcher
Copy link
Contributor

If it doesn't break anything then it seems like a good idea. I have never tried the platform option and don't know how it works. If there is no manylinux version of a package, does pip get the regular version instead (as though no platform was specified) or does it error because it couldn't find a version for the specified platform?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants