Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinks in subdirectories break Stack #1191

Closed
gergoerdi opened this issue Mar 10, 2020 · 3 comments · Fixed by #1192
Closed

Symlinks in subdirectories break Stack #1191

gergoerdi opened this issue Mar 10, 2020 · 3 comments · Fixed by #1192
Labels
easy Requires virtually no knowledge of the clash compiler external bug

Comments

@gergoerdi
Copy link
Contributor

OK OK OK I know this is a Stack issue. I hate myself for even bringing this up. But.

Stack chokes on installing Clash from Git due to a very stupid, very superficial problem: symlinks in subdirectories. Here's a Stack ticket, there are others on this issue as well: commercialhaskell/stack#5004 Here's a comment from the maintainer: commercialhaskell/stack#4913 (comment) The summary is that things are not looking too good for this.

But what are these problematic symlinks in the Clash source tree? I am glad you asked, because the list is not long:

  • /docs/general/LICENSE -> ../../LICENSE

Yyyyep. Just getting rid of that single multi-level symlink would solve this issue (which I have verified in https://github.com/gergoerdi/clash-compiler/tree/stack-issue-5004-workaround). And I don't imagine its content changes so much that maintaining a separate copy in this directory would be that much of a problem...

@alex-mckenna alex-mckenna added the easy Requires virtually no knowledge of the clash compiler label Mar 10, 2020
@martijnbastiaan
Copy link
Member

Yeah, I'm fine with copying it. If you open a PR I'll merge it :).

@martijnbastiaan
Copy link
Member

Although I'm curious why it doesn't fail for clash-prelude/CHANGELOG.md?

@gergoerdi
Copy link
Contributor Author

I think it needs to be a symlink that points out by at least two levels... 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Requires virtually no knowledge of the clash compiler external bug
Projects
None yet
3 participants