Misleading functions in clash-prelude-hedgehog

[martijnbastiaan]

E.g., genSigned can generate results outside of its given range:

clash-compiler/clash-prelude-hedgehog/src/Clash/Hedgehog/Sized/Signed.hs

Lines 28 to 34 in 690fbea

	genSigned :: (MonadGen m, KnownNat n) => Range (Signed n) -> m (Signed n)
	genSigned range =
	Gen.frequency
	[ (60, Gen.integral range)
	, (20, Gen.constant minBound)
	, (20, Gen.constant maxBound)
	]

I think this is misleading at best. We probably want to inspect the given range and generate its extreme values.

[alex-mckenna]

Yes, that seems reasonable. Do you want to make a PR or should I, it's just a case of changing

minBound ~~> Range.lowerBound range
maxBound ~~> Range.upperBound range

[martijnbastiaan]

Go for it

[martijnbastiaan]

We've released v1.6.3, which includes a fix for this issue.