Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed Caption Control Button Initial setting not syncd with caption display #14

Open
angrave opened this issue Nov 15, 2022 · 0 comments

Comments

@angrave
Copy link
Contributor

angrave commented Nov 15, 2022

If Closed Captions control button in the control bar is initially enabled, closed captions need to be toggled off and on to display captions.
Todo: verify the behavior of the closed captions in the settings panel. Originally it was assumed this was due to the video element being out of sync with the boolean state stored in the react model when it is first initialized. However the captions are displayed by other react code (src/screens/Watch/Components/Overlays/ClosedCaption/index.js).

See

grep -r 'openCC' src
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant