Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialized status to respect cluster-api contracts #133

Open
lbrunOVH opened this issue Oct 21, 2024 · 0 comments · May be fixed by #134
Open

Fix initialized status to respect cluster-api contracts #133

lbrunOVH opened this issue Oct 21, 2024 · 0 comments · May be fixed by #134

Comments

@lbrunOVH
Copy link
Contributor

Hi,

In the cluster-api documentation, it says that the 'initialized' status should be set to true only when the control-plane has been contactable once.
However, currently we set 'initialized' status when the TenantControlPlane has its Status.Kubernetes.Version.Status not nil. (https://github.com/clastix/cluster-api-control-plane-provider-kamaji/blob/master/controllers/kamajicontrolplane_controller.go#L195)
Which means that when the TenantControlPlane is still in "Provisionning", we have already have set 'initialized' status before the deployment is ready.
I discovered this when I had an issue with my ETCD DataStore, the deployment was not yet created and the cluster-api was already trying to contact the APIServer.

Linked to cluster-api documentation/code about control-plane contract and the 'initialized' status:
https://cluster-api.sigs.k8s.io/developer/providers/control-plane#required-status-fields
https://github.com/kubernetes-sigs/cluster-api/blob/main/api/v1beta1/condition_consts.go#L74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant