Improve scroll container behaviour #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
clauderic
reviewed
Mar 12, 2019
clauderic
reviewed
Mar 12, 2019
clauderic
approved these changes
Mar 13, 2019
clauderic
reviewed
Mar 19, 2019
| } | ||
|
|
||
| export function getScrollingParent(el) { | ||
| if (!el) { |
There was a problem hiding this comment.
This might need to be !(el instanceof HTMLElement)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subissue of #501
This PR improves the scroll container default by checking the element's ancestors for appropriate scrolling styles. It also replaces references to
this.containerwith those tothis.scrollContainerin the autoscrolling logic.This mainly impacts the nested list use case; other use cases (including window as scroll container) should remain unaffected.
If this gets merged in, I'll put up a commit in #501 to consolidate the changes.
Sorry for the terrible GIF quality