Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery Code must be exactly 10 characters #21

Open
claudiodekker opened this issue Dec 11, 2022 · 1 comment
Open

Recovery Code must be exactly 10 characters #21

claudiodekker opened this issue Dec 11, 2022 · 1 comment
Labels
bladebones Bladebones adapter package related bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@claudiodekker
Copy link
Owner

This is a very minor bug, but essentially when you enter a recovery code with a dash separator (as it is displayed during code generation), the code will be 11 characters long instead of 10, while the recovery code input itself only allows 10 characters exactly.

The obvious workaround is to simply enter the code without the separator, but the problem there is that those who store their recovery codes in a password manager, will likely copy-paste the code as-is with the separator, in which case the browser likely truncates the input field, making the code one character too short, causing the code to be considered invalid.

To fix this, we'll want to keep the "min" length as-is, but make the "max" length 11.

@claudiodekker claudiodekker added bug Something isn't working good first issue Good for newcomers labels Dec 11, 2022
@claudiodekker claudiodekker added this to the 1.0.0 milestone Dec 22, 2022
@claudiodekker claudiodekker reopened this Dec 23, 2022
@claudiodekker
Copy link
Owner Author

Keeping this one open until 1.0 is released.

@claudiodekker claudiodekker transferred this issue from another repository Apr 2, 2023
@claudiodekker claudiodekker added the bladebones Bladebones adapter package related label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bladebones Bladebones adapter package related bug Something isn't working good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

1 participant