-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Boundary Condition Should Accept dt
as an Argument
#507
Comments
Can you explain (for me) why a boundary condition could depend on |
In the case I ran into an approximation of a time derivative is needed to calculate an incoming wave form while allowing an outgoing wave at the same time (not exactly a paddle but still in a idealized wave-tank). Randy wrote up a short IPython notebook at http://nbviewer.ipython.org/url/faculty.washington.edu/rjl/notebooks/Wavetank_BC.ipynb which describes what we were trying to do. |
Thanks. I guess this would only ever be needed in the Classic solvers, and never in a method-of-lines-solver, right? But it's probably best to keep the same BC API across all solvers. |
Thinking about this some more and looking at what I've done in other problems where an incoming wave is specified, I'm not sure what I suggested in that notebook is correct -- the ghost cell value should perhaps be based on spatial derivatives not temporal derivatives. I will think about this further. Also, I just noticed that Before adding it to PyClaw, let's think further about whether we should instead delete it from classic. |
I was under the impression that there might be BCs that may be dependent on time derivatives, for instance maybe a system that contains reactions would require the approximation of a time derivative. On the other hand I cannot say that I have ever needed this before the above application. |
The Fortran versions of Clawpack accept
dt
as an argument to the boundary conditions which is useful for certain types of boundary conditions (paddle BCs in my case). We can simply add this to the calling signature but this will again break backwards compatibility.The text was updated successfully, but these errors were encountered: