Upgrade to React 15.4.1 #108
Conversation
+ This is due to React DOM now exporting some of the addons
|
+1 |
jacehensley-wf
force-pushed
the
upgrade_to_react_15_4/dev
branch
from
ad9931a to
78061a1
Compare
| @@ -429,7 +429,7 @@ _convertEventHandlers(Map args) { | |||
| args.forEach((propKey, value) { | |||
| var eventFactory = _eventPropKeyToEventFactory[propKey]; | |||
| if (eventFactory != null && value != null) { | |||
| args[propKey] = (events.SyntheticEvent e, [String domId, Event event]) => zone.run(() { | |||
| args[propKey] = (events.SyntheticEvent e, [_, __]) => zone.run(() { | |||
There was a problem hiding this comment.
For my own knowledge @jacehensley-wf - what is the reason for relaxing the type / obfuscating the arguments here?
There was a problem hiding this comment.
The reason is because now the second arg passed to this is now of type EventImpl. And because we really don't care what it is we can just ignore it.
| @@ -5,7 +5,7 @@ | |||
| <title></title> | |||
|
|
|||
| <script src="packages/react/react_prod.js"></script> | |||
| <script src="packages/react/react_dom_prod.js"></script> | |||
| <script src="packages/react/react_dom.js"></script> | |||
There was a problem hiding this comment.
Why was this changed?
There was a problem hiding this comment.
Oh, I just changed all react_dom_prod.js to react_dom.js, this one can be reverted
| <a href="/react_test_utils_test.html"> | ||
| Run <code>react_test_utils_test.html</code> | ||
| </a> | ||
| </li> |
There was a problem hiding this comment.
Niiiiiiiiice. Would you mind adding links to the js_interop_helpers_test files as well, while you're in here?
There was a problem hiding this comment.
Added in decc8cd
+10 |
|
React 15.4.1 just got released, so this PR now bumps to that. |
|
+1 |
|
@trentgrover-wf @greglittlefield-wf this is ready for merge / tag. |
+10 Merging |
Ultimate Problem:
React 15.4.1 just got release and it came with lots of good stuff.
Solution:
Testing Suggestions:
--
FYA: @trentgrover-wf @greglittlefield-wf @clairesarsam-wf @aaronlademann-wf @joelleibow-wf