Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing description about the required "[Global]" section for a distribution.ini #8

Open
cosmo0920 opened this issue Oct 19, 2016 · 0 comments
Open

Missing description about the required "[Global]" section for a distribution.ini #8

cosmo0920 opened this issue Oct 19, 2016 · 0 comments

Comments

@cosmo0920
Copy link
Contributor

I noticed that distribution.ini which does not have [Global] section has no effect.
Because https://dxr.mozilla.org/mozilla-central/source/browser/components/distribution.js#323 implies that when missing [Global] section in distribution.ini or missing id, version, and about in [Global], firefox will not apply customizations from distribution.ini.
I think that this is a pitfall.
How we treat this booby trap?
@piroor piroor changed the title Customization with distribution.ini has some pitfall Missing description about the required "[Global]" section for a distribution.ini Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cosmo0920