Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage crawler exceptions: Invalid comment length #19

Open
brphelps opened this issue Mar 12, 2020 · 2 comments
Open

Triage crawler exceptions: Invalid comment length #19

brphelps opened this issue Mar 12, 2020 · 2 comments
Assignees

Comments

@brphelps
Copy link
Contributor

exceptions | summarize InvalidCommentLength = countif(outerMessage contains "invalid comment length.")

@brphelps
Copy link
Contributor Author

When triaging, make sure to identify whether this issue should or shouldn't be happening -- if it's not truly exceptional, try to convert to a less interesting tracing method (e.g. a warning trace).

@jeffmendoza jeffmendoza self-assigned this Mar 12, 2020
@jeffmendoza
Copy link
Member

jeffmendoza commented Mar 12, 2020

Looks like this is coming from a library that we use to handle zip files. Most likely an invalid zip in a package/repo we are harvesting (invalid according to the library). Seems like it should be a log and move on

Problem is the code where we get the message is here:
ghcrawler/lib/crawler.js:132
https://github.com/clearlydefined/crawler/blob/master/ghcrawler/lib/crawler.js#L132

Not sure how to filter there, or if there is somewhere else to catch these errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants