Skip to content
This repository has been archived by the owner on Apr 29, 2021. It is now read-only.

Solidity-coverage missing dependencies with web3 1.0.0-beta.51 #93

Closed
Andreadinenno opened this issue May 29, 2019 · 9 comments
Closed
Labels
bug Something isn't working

Comments

@Andreadinenno
Copy link
Contributor

This issue is a remainder to check updates of solidity-coverage, since in its last implementation it is using web3 beta.50.

This is needed because of an issue of web3, that causes roughly half of our test to fail when run under the solidity-coverage environment, while passing using the latest Truffle/Ganache.

@zoenolan zoenolan added the bug Something isn't working label May 30, 2019
@zoenolan
Copy link
Contributor

zoenolan commented Jun 5, 2019

This is currently blocking #97

@zoenolan
Copy link
Contributor

zoenolan commented Jun 5, 2019

A beta version of solidity-coverage with support for Solidity 0.5.x but is currently untested

@zoenolan
Copy link
Contributor

and after testing the latest beta version that is still producing the error.

@zoenolan
Copy link
Contributor

New release of sol-coverage, not a simple drop in upgrade

@zoenolan
Copy link
Contributor

zoenolan commented Dec 6, 2019

v0.6.4 released a while back

@Andreadinenno
Copy link
Contributor Author

Updated to the latest version of solidity-coverage yet same errors when running the coverage.
Steps to reproduce:

  • remove node modules with rm -rf node_modules
  • update solidity-coverage in package.json to version 0.6.4
  • fresh install dependencies npm install
  • run test coverage tool npm run coverage

Error encountered:
TypeError: Overriding function changes state mutability from "view" to "nonpayable" for a bunch of function implementing the IERC777

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Jan 18, 2020
@zoenolan zoenolan removed the Stale label Jan 18, 2020
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Feb 18, 2020
@zoenolan zoenolan removed the Stale label Feb 18, 2020
@Andreadinenno
Copy link
Contributor Author

Fixed in #143

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants