-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posterior Sampling for PVAE #120
Comments
Hi @ErfanMowlaei , Thank you for opening this issue. |
Hi @clementchadebec , I appreciate your help. That is correct and what I am looking for. Also I noticed that the sampler for PVAE has learnable parameters for mu and log_var. However, the number of parameters for mu equals to the number of latent dimensions, but for log_var there is only one parameter. Is this a bug? |
Hi @ErfanMowlaei, Ok, in such a case you can use the samplers provided in the library such as the As to the prior parameters, I hope this helps. Best, Clément |
Hi @clementchadebec , Thank you very much, it was my bad for not carefully studying the library. Well for our project |
Hi @ErfanMowlaei , No worries! I am happy to see that this improved your results :) Best, Clément |
Hi @clementchadebec , As good as GaussianMixtureSampler is, it is using an euclidean geometry and therefore we have to use lots of components to get some decent results, which might not be the best we can get out of the trained model. I was wondering if instead of sklearn's GMM you could use geomstats to make it possible to use the right geometry for the sampler. |
Hi @ErfanMowlaei , |
@clementchadebec |
I was wondering if it is possible for you to add posterior sampling to PVAE model. The problem with prior sampling is that the embedding space could be sparse and in this case prior sampling would do terrible.
The text was updated successfully, but these errors were encountered: