feat: update repo with latest changes from t3-turbo #85
Conversation
There was a problem hiding this comment.
Hey! Nice PR, was checking out your code because I want to start a project with this T3 template but some things seemed out of date.
As I was looking through it, I noticed something with the middleware.
According to Clerk's docs, withClerkMiddleware is deprecated in favor of this:
import { authMiddleware } from "@clerk/nextjs";
export default authMiddleware();
export const config = {
matcher: ["/((?!.*\\..*|_next).*)", "/", "/(api|trpc)(.*)"],
};That is of course if you decide to update the @clerk/nextjs package to v4.21.8.
There was a problem hiding this comment.
Why not, updated! Did you find anything else that was not working as expected?
|
Hey @perkinsjr, can you also take a look? |
|
I can but the PR is huge so it's going to take me a way to review all the code, functionality and production deployments |
|
Totally understandable! Most code came directly from the https://github.com/t3-oss/create-t3-turbo, I've just did a sort merge from both. |
|
Now that I think of it, maybe we can actually not have renovate in this repo, and we'll just cherry-pick commits from the OG repo... Not sure 🤷 |
|
any update on this one? |
|
I've given up on this PR. This was not a trivial merge, but it got completely ignored. |
Closes #84.
From local testing everything seems to be working, but it might need some polishing.