Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPE_COLLATE #136

Open
SimonSayID opened this issue Jan 29, 2018 · 1 comment
Open

TYPE_COLLATE #136

SimonSayID opened this issue Jan 29, 2018 · 1 comment

Comments

@SimonSayID
Copy link

SimonSayID commented Jan 29, 2018

the source code seems don't have the corresponding case for assignment, only the TYPE_SQLTYPE have.
code:

else if (sf->tokenvec[left].type == TYPE_COLLATE &&
                   sf->tokenvec[left+1].type == TYPE_BAREWORD) {
                         if (strchr(sf->tokenvec[left+1].val, '_') != NULL) {
                             sf->tokenvec[left+1].type = TYPE_SQLTYPE;
                             left = 0;
                        }
...
}

doesn't have something like

sf->tokenvec[left].type = TYPE_COLLATE 
@client9
Copy link
Owner

client9 commented Mar 6, 2018

Hello! thanks for writing it. I'd would love a test case before commenting further (and of course a Pull Request!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants