Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added missing 'raise' in get_spacings to actually raise ValueError #105

Merged
merged 1 commit into from
Apr 7, 2022
Merged

added missing 'raise' in get_spacings to actually raise ValueError #105

merged 1 commit into from
Apr 7, 2022

Conversation

JuliaKukulies
Copy link
Member

Same fix as #103 for dev, issue #48 should be solved with this

@JuliaKukulies JuliaKukulies added the bug Code that is failing or producing the wrong result label Apr 6, 2022
@freemansw1 freemansw1 self-requested a review April 7, 2022 03:19
@freemansw1 freemansw1 self-assigned this Apr 7, 2022
@freemansw1 freemansw1 added this to the Version 1.3 milestone Apr 7, 2022
@freemansw1
Copy link
Member

Thanks for porting this over Julia!

@freemansw1 freemansw1 merged commit b029a35 into tobac-project:dev Apr 7, 2022
@w-k-jones w-k-jones mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freemansw1 freemansw1 freemansw1 approved these changes

Assignees

@freemansw1 freemansw1

Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Milestone
Version 1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@JuliaKukulies @freemansw1