Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error if non-constant variable is specified as an input #441

Open
chrispcampbell opened this issue Mar 7, 2024 · 1 comment
Open

Comments

@chrispcampbell
Copy link
Contributor

See discussion #440 for more details. Currently the compiler will not throw an error in the case where an input variable specified in the spec.json file is not a constant, so if the user accidentally tries to configure a non-constant to be an input, the input values will not take effect and it is hard to diagnose. Only constants should be allowed to be configured as an input, so we should detect the case where an input is configured for a non-constant and report it as a hard error.

@ToddFincannonEI
Copy link
Collaborator

I would be happy to "fix this with documentation" saying "don't do that". It doesn't make much sense to set anything but a constant from inputs, so I doubt it comes up often in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants