feat: allow for overriding data variables and lookups at runtime #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arations of arrays and mappings
…ted for Wasm case)
…output either JavaScript or C code
…it is not clear that we really need it yet
…he latter was causing duplicate items, since it includes a mix of const, aux, and level vars)
… and undefined lookups
…en lookup is NULL or empty
…ture with lookups arg
|
I resolved one last minute issue with the runtime-async tests, otherwise I think this is ready to be merged. As with the other recent branches and PRs, Todd won't have time to review this before it gets merged, so we will merge but then keep the changes queued up on main before we publish official packages. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472
This updates the compiler so that it includes a
setLookupfunction in generated C and JS models, and then updates the runtime packages to allow for supplying lookup overrides via a newoptionsparameter forModelRunner.runModel.See this issue comment for more details on the changes included here. TL;DR this mostly adds new functionality, and there should be no impact on existing projects.
/cc @ToddFincannonEI