Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing traces when using kernel-tracing #443

Open
RafaelGSS opened this issue Mar 7, 2023 · 0 comments
Open

Missing traces when using kernel-tracing #443

RafaelGSS opened this issue Mar 7, 2023 · 0 comments
Labels

Comments

@RafaelGSS
Copy link
Contributor

RafaelGSS commented Mar 7, 2023

V8 might have changed how it behaves with --perf-basic-prof.

Example:

import fs  from 'node:fs'
// File with URLs
const contents = fs.readFileSync('./out-positive.txt', 'utf8').split('\n').filter(l => l.length > 3)

let result = 0

// warmup
for (let content of contents) {
  result = new URL(content).toString().length
}

process._rawDebug('benchmark starts')

for (let content of contents) {
  result = new URL(content).toString().length
}

If someone else wants to investigate it before me, use the out-positive.txt.

Note: you can't compare the result with Node.js <= v18 because URL has changed in v19. You should compare it against other profilers (pprof, CDT, Apple Instrument, linux_perf)

@RafaelGSS RafaelGSS transferred this issue from clinicjs/node-clinic-flame Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant