Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS support to client proxy #743

Open
DerGuteMoritz opened this issue Feb 14, 2025 · 0 comments
Open

Add HTTPS support to client proxy #743

DerGuteMoritz opened this issue Feb 14, 2025 · 0 comments

Comments

@DerGuteMoritz
Copy link
Collaborator

DerGuteMoritz commented Feb 14, 2025

Aleph's HTTP client has proxy support (via proxy-options) but it doesn't support HTTPS connections towards the proxy server, i.e. the initial CONNECT request is always sent in plain. Note that connecting to destination hosts via HTTPS is still possible this way. However, it would still be good to also support a secure client <-> proxy connection for defense in depth purposes or for using proxies in an untrusted network environment.

Implementation-wise, this would probably entail adding an optional ssl-context key to proxy-options and then adding a second SslHandler to the pipeline before the proxy handlers. As a consequence, we might have to fix some of the existing code expecting only one SslHandler to be present in the channel pipeline. See netty/netty#11418 for somebody running into that very situation.

See also this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant