Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paredit fns throw on invalid clojure but valid rewrite-clj constructs #336

Open
lread opened this issue Feb 5, 2025 · 0 comments
Open

Comments

@lread
Copy link
Collaborator

lread commented Feb 5, 2025

Version
1.1.49

Platform
All

Symptom
The paredit API will throw when it is inspecting certain valid rewrite-clj constructs.
An example of an invalid clojure but valid rewrite-clj construct is an unbalanced map: {:a}.

Reproduction

(-> "{:a} :b"
    z/of-string
    pe/slurp-forward
    z/root-string)

Actual behavior

;; => Execution error (IllegalArgumentException) at rewrite-clj.node.seq/eval12858$map-seq-fn (seq.cljc:107).
;;    No value supplied for key: :a

Expected behavior
This should be a noop for slurp:

;; => "{:a} :b"

Diagnosis
Paredit is using sexpr internally. We'll stop doing that.

Action
Looking at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant