Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the hash functions of ProductValue and RowRef the same #1049

Closed
Centril opened this issue Apr 9, 2024 · 2 comments
Closed

Make the hash functions of ProductValue and RowRef the same #1049

Centril opened this issue Apr 9, 2024 · 2 comments
Assignees
@Centril
Labels
enhancement New feature or request

Comments

@Centril
Copy link
Contributor

Centril commented Apr 9, 2024

This is helped by #1048.
We also need to define a hash function on BSATN-encoded AlgebraicValues.
cc @gefjon
@Centril Centril added enhancement New feature or request abi-break A PR that makes an ABI breaking change performance labels Apr 9, 2024
@Centril Centril self-assigned this Apr 9, 2024
@Centril
Copy link
Contributor Author

Centril commented Apr 22, 2024

Will be fixed by #1107

@bfops bfops removed the performance label Apr 22, 2024
@Centril Centril removed the abi-break A PR that makes an ABI breaking change label Apr 26, 2024
@Centril
Copy link
Contributor Author

Centril commented Apr 30, 2024

Fixed in #1163.

@Centril Centril closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Centril Centril

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bfops @Centril