Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - spacetime generate should not overwrite non-SpacetimeDB files #1786

Open
1 task
bfops opened this issue Oct 1, 2024 · 1 comment
Open
1 task

CLI - spacetime generate should not overwrite non-SpacetimeDB files #1786

bfops opened this issue Oct 1, 2024 · 1 comment
Assignees

Comments

@bfops
Copy link
Collaborator

bfops commented Oct 1, 2024

Background

As @jdetter noted in https://github.com/clockworklabs/SpacetimeDB/pull/1774/files#r1781948491, spacetime generate might happily overwrite files that were user-generated.

Definition of Done

  • spacetime generate should only (over)write a file if it either doesn't exist, or if it starts with the "this file is autogenerated by SpacetimeDB" header

Priority

@bfops honestly doesn't think this should be a P1, but others could reasonable disagree. Marking this as a P1 so we have the discussion.

@cloutiertyler
Copy link
Contributor

I looked at this and decided it should be a P2 for this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants