Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: avoid materializing ProductValue in CommittedState::merge #2013

Open
Centril opened this issue Nov 27, 2024 · 1 comment
Open

perf: avoid materializing ProductValue in CommittedState::merge #2013

Centril opened this issue Nov 27, 2024 · 1 comment
Assignees
@Centril

Comments

@Centril
Copy link
Contributor

Centril commented Nov 27, 2024

Instead:

  1. return a list of RowRefs pointing into the committed state,
  2. return a Table of all the deleted rows.

Hand these to the commitlog which will convert to bsatn and subscriptions engine, which can work with bflatn directly.
@Centril Centril self-assigned this Nov 27, 2024
This was referenced Nov 27, 2024
Open
Open
@Centril
Copy link
Contributor Author

Centril commented Nov 27, 2024

This is a prerequisite of #2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Centril Centril

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Centril