Add Layout.fixed: bool
for a fast path in eq_row_in_page
& row_type_visitor
#2025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds to
Layout
whether it is the layout of a "fixed type" and not the layout of a var-len type's fixed component.This is then exploited to 2x-10x speed up
eq_row_in_page
and speed uprow_type_visitor
for the fixed len case at the cost of some minor regression for small VLOs.This in turn will speed up insertions and subscriptions.
API and ABI breaking changes
None
Expected complexity level and risk
2, fairly self-contained.