Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal handling #2133

Open
kim opened this issue Jan 17, 2025 · 2 comments
Open

Signal handling #2133

kim opened this issue Jan 17, 2025 · 2 comments

Comments

@kim
Copy link
Contributor

kim commented Jan 17, 2025 •
edited
Loading

Since #2011 , it is no longer possible to stop spacetimedb start by ^C. Killing the parent (spacetimedb-cli) will leave the child (spacetimedb-standalone) running.

OS: Linux
@kim
Copy link
Contributor Author

kim commented Jan 17, 2025

Of course, sometimes it does work.
I wonder if it may have to do with using the blocking process::Command inside an async function. Afaik, tokio‘s process::Command has extra machinery for signal handling.

@coolreader18
Copy link
Collaborator

Going back to using exec() should fix this on unix; I might look into whether this might also happen on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kim @coolreader18