Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Provide Arbitrary impls for Hash and DataKey #517

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

kim
Copy link
Contributor

@kim kim commented Nov 1, 2023

Description of Changes

Allows to remove custom strategies for the commit log types (in core), and may become useful for future property testing efforts.

This is stacked on top of #495. Do not merge until after #495 is landed.

API and ABI

  • This is a breaking change to the module ABI
  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

Expected complexity level and risk

1

@kim kim requested a review from Centril November 1, 2023 17:26
Allows to remove custom strategies for the commit log types (in core),
and may become useful for future property testing efforts.
@kim kim force-pushed the kim/arbitrary-hash-datakey branch from 0bcfd3c to 8059574 Compare November 6, 2023 09:32
@kim
Copy link
Contributor Author

kim commented Nov 6, 2023

Turns out #[cfg_attr(any(test, feature = "proptest"), ..)] is needed to allow using the impls in this crate's tests as well as in dependants.

@kim kim enabled auto-merge (rebase) November 6, 2023 09:34
@kim kim merged commit 0a4c2f1 into master Nov 6, 2023
5 checks passed
@kim kim deleted the kim/arbitrary-hash-datakey branch November 6, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants