Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undef-all: skip unmapping of default imports #751

Merged
merged 3 commits into from
May 18, 2022
Merged

undef-all: skip unmapping of default imports #751

merged 3 commits into from
May 18, 2022

Conversation

yuhan0
Copy link
Contributor

@yuhan0 yuhan0 commented May 14, 2022

See clojure-emacs/cider#3194

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • You've updated the README (if adding/changing middleware)

@yuhan0 yuhan0 force-pushed the undef-all-skip-default-imports branch 2 times, most recently from 4d62dc7 to c8d13ab Compare May 14, 2022 10:06
@bbatsov
Copy link
Member

bbatsov commented May 15, 2022

Looks good to me. Just mention this bugfix in the changelog and we're good to go.

@vemv vemv mentioned this pull request May 18, 2022
Closed
@vemv vemv merged commit dfa2f07 into clojure-emacs:master May 18, 2022
@vemv
Copy link
Member

vemv commented May 18, 2022

I'll create one small PR (unrelated) then cut a release

@vemv
Copy link
Member

vemv commented May 18, 2022

The changelog section shouldn't have touched ## 0.28.3 (2022-02-22) btw!

For next time 😄

@yuhan0 yuhan0 deleted the undef-all-skip-default-imports branch May 18, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuhan0 @bbatsov @vemv